linux-kernel - Re: [PATCH 09/36] tty/vt: consolemap: use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9ef796b-54e7-e9ca-9bae-fbec5a976bfd@linux.intel.com>
Date:   Tue, 7 Jun 2022 16:40:27 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Jiri Slaby <jslaby@...e.cz>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 09/36] tty/vt: consolemap: use | for binary addition

On Tue, 7 Jun 2022, Ilpo Järvinen wrote:

> On Tue, 7 Jun 2022, Jiri Slaby wrote:
> 
> > @@ -788,7 +788,7 @@ int con_get_unimap(struct vc_data *vc, ushort ct, ushort __user *uct, struct uni
> >  						continue;
> >  					if (ect < ct) {
> >  						unilist[ect].unicode =
> > -							(i<<11)+(j<<6)+k;
> > +							(i<<11) | (j<<6) | k;
> 
> I'd have added also the spaces around <<.

Ah, nevermind. I see the line gets changed later on to something entirely 
different.

-- 
 i.