linux-kernel - Re: [PATCH 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f81b8b8f-b811-3be2-5dda-139dc1bd7bdd@linux.intel.com>
Date:   Tue, 7 Jun 2022 11:23:27 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     Nicolin Chen <nicolinc@...dia.com>, jgg@...dia.com,
        joro@...tes.org, will@...nel.org, marcan@...can.st,
        sven@...npeter.dev, robin.murphy@....com, robdclark@...il.com,
        m.szyprowski@...sung.com, krzysztof.kozlowski@...aro.org,
        agross@...nel.org, bjorn.andersson@...aro.org,
        matthias.bgg@...il.com, heiko@...ech.de, orsonzhai@...il.com,
        baolin.wang7@...il.com, zhang.lyra@...il.com, wens@...e.org,
        jernej.skrabec@...il.com, samuel@...lland.org,
        jean-philippe@...aro.org, alex.williamson@...hat.com
Cc:     baolu.lu@...ux.intel.com, suravee.suthikulpanit@....com,
        alyssa@...enzweig.io, alim.akhtar@...sung.com, dwmw2@...radead.org,
        yong.wu@...iatek.com, mjrosato@...ux.ibm.com,
        gerald.schaefer@...ux.ibm.com, thierry.reding@...il.com,
        vdumpa@...dia.com, jonathanh@...dia.com, cohuck@...hat.com,
        iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org
Subject: Re: [PATCH 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain
 and device/group

On 2022/6/6 14:19, Nicolin Chen wrote:
> +/**
> + * iommu_attach_group - Attach an IOMMU group to an IOMMU domain
> + * @domain: IOMMU domain to attach
> + * @dev: IOMMU group that will be attached

Nit: @group: ...

> + *
> + * Returns 0 on success and error code on failure
> + *
> + * Specifically, -EMEDIUMTYPE is returned if the domain and the group are
> + * incompatible in some way. This indicates that a caller should try another
> + * existing IOMMU domain or allocate a new one.
> + */
>   int iommu_attach_group(struct iommu_domain *domain, struct iommu_group *group)
>   {
>   	int ret;

Best regards,
baolu