linux-kernel - Re: [PATCH v5 0/7] can: refactoring of can-dev module and of Kbuild

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44670e69-6d67-c6c7-160c-1ae6e740aabb@hartkopp.net>
Date:   Tue, 7 Jun 2022 22:51:54 +0200
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     Vincent MAILHOL <mailhol.vincent@...adoo.fr>,
        linux-can <linux-can@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Max Staudt <max@...as.org>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v5 0/7] can: refactoring of can-dev module and of Kbuild



On 07.06.22 22:27, Marc Kleine-Budde wrote:
> On 07.06.2022 22:12:46, Oliver Hartkopp wrote:
>> So what about:
>>
>>    symbol: CONFIG_NETDEVICES
>>    |
>>    +-> CAN Device Drivers
>>        symbol: CONFIG_CAN_DEV
>>        |
>>        +-> software/virtual CAN device drivers
>>        |   (at time of writing: slcan, vcan, vxcan)
>>        |
>>        +-> hardware CAN device drivers with Netlink support
>>            symbol: CONFIG_CAN_NETLINK (matches previous CONFIG_CAN_DEV)
>>            |
>>            +-> CAN bit-timing calculation (optional for all drivers)
>>            |   symbol: CONFIG_CAN_BITTIMING
>>            |
>>            +-> CAN rx offload (optional but selected by some drivers)
>>            |   symbol: CONFIG_CAN_RX_OFFLOAD
>>            |
>>            +-> CAN devices drivers
>>                (some may select CONFIG_CAN_RX_OFFLOAD)
>>
>> (I also added 'hardware' to CAN device drivers with Netlink support) to have
>> a distinction to 'software/virtual' CAN device drivers)
> 
> The line between hardware and software/virtual devices ist blurry, the
> new can327 driver uses netlink and the slcan is currently being
> converted....

Right, which could mean that slcan and can327 should be located in the 
'usual' CAN device driver section and not in the sw/virtual device section.

The slcan and can327 need some kind of hardware - while vcan and vxcan 
don't.

Best regards,
Oliver