[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220607230537.70020736@heffalump.sk2.org>
Date: Tue, 7 Jun 2022 23:05:37 +0200
From: Stephen Kitt <steve@....org>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: shmobile: Use backlight helper
On Tue, 7 Jun 2022 20:31:32 +0200, Stephen Kitt <steve@....org> wrote:
> backlight_properties.fb_blank is deprecated. The states it represents
> are handled by other properties; but instead of accessing those
> properties directly, drivers should use the helpers provided by
> backlight.h.
Apologies for the misleading boilerplate, this patch came about as a result
of cleaning up fb_blank usage but doesn't involve fb_blank itself.
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@....org>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: dri-devel@...ts.freedesktop.org
> ---
> drivers/gpu/drm/shmobile/shmob_drm_backlight.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c
> b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c index
> f6628a5ee95f..794573badfe8 100644 ---
> a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c +++
> b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c @@ -18,11 +18,7 @@ static
> int shmob_drm_backlight_update(struct backlight_device *bdev) struct
> shmob_drm_connector *scon = bl_get_data(bdev); struct shmob_drm_device
> *sdev = scon->connector.dev->dev_private; const struct
> shmob_drm_backlight_data *bdata = &sdev->pdata->backlight;
> - int brightness = bdev->props.brightness;
> -
> - if (bdev->props.power != FB_BLANK_UNBLANK ||
> - bdev->props.state & BL_CORE_SUSPENDED)
> - brightness = 0;
> + int brightness = backlight_get_brightness(bdev);
>
> return bdata->set_brightness(brightness);
> }
>
> base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56
> --
> 2.30.2
>
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists