linux-kernel - Re: [PATCH] samples: Use KSYM_NAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <491cda3a-2e2e-fde7-1b4d-2261b95651fe@loongson.cn>
Date:   Wed, 8 Jun 2022 08:20:28 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] samples: Use KSYM_NAME_LEN for fprobe and kprobes



On 06/08/2022 12:17 AM, Masami Hiramatsu (Google) wrote:
> On Tue,  7 Jun 2022 17:35:36 +0800
> Tiezhu Yang <yangtiezhu@...ngson.cn> wrote:
>
>> It is better and enough to use KSYM_NAME_LEN for fprobe and kprobes
>> in samples, no need to define and use the other values.
>>
>
> This is good for kprobe and kretprobe examples because it will get
> a single symbol name, but not good for the fprobe. It can take
> several comma separated symbols.
>
> -----
> static int __init fprobe_init(void)
> {
> ...
>         /* Comma separated symbols */
>         symbuf = kstrdup(symbol, GFP_KERNEL);
>         if (!symbuf)
>                 return -ENOMEM;
>         p = symbuf;
>         count = 1;
>         while ((p = strchr(++p, ',')) != NULL)
>                 count++;
>
>         pr_info("%d symbols found\n", count);
> -----
>
> Can you drop the fprobe_example.c part?
>

OK, I will send v2 later, thank you.

Thanks,
Tiezhu