linux-kernel - Re: [PATCH 2/2] ASoC: qcom: soundwire: Add software clock gating requirement check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202206081054.vVkYPkJt-lkp@intel.com>
Date:   Wed, 8 Jun 2022 10:29:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>,
        agross@...nel.org, bjorn.andersson@...aro.org, lgirdwood@...il.com,
        broonie@...nel.org, robh+dt@...nel.org, quic_plai@...cinc.com,
        bgoswami@...cinc.com, perex@...ex.cz, tiwai@...e.com,
        srinivas.kandagatla@...aro.org, quic_rohkumar@...cinc.com,
        linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        swboyd@...omium.org, judyhsiao@...omium.org, vkoul@...nel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
Subject: Re: [PATCH 2/2] ASoC: qcom: soundwire: Add software clock gating
 requirement check

Hi Srinivasa,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on broonie-sound/for-next]
[cannot apply to linus/master v5.19-rc1 next-20220607]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Srinivasa-Rao-Mandadapu/Add-software-clock-gating-requirement-check/20220607-203739
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-randconfig-a006 (https://download.01.org/0day-ci/archive/20220608/202206081054.vVkYPkJt-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/86aa15d36b06f7b73938f00f9ad99eff75a94a94
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Srinivasa-Rao-Mandadapu/Add-software-clock-gating-requirement-check/20220607-203739
        git checkout 86aa15d36b06f7b73938f00f9ad99eff75a94a94
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/soundwire/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/soundwire/qcom.c:668:6: error: use of undeclared identifier 'data'
           if (data->sw_clk_gate_required)
               ^
   drivers/soundwire/qcom.c:1509:7: error: use of undeclared identifier 'data'
                   if (data->sw_clk_gate_required)
                       ^
   2 errors generated.


vim +/data +668 drivers/soundwire/qcom.c

   659	
   660	static int qcom_swrm_init(struct qcom_swrm_ctrl *ctrl)
   661	{
   662		u32 val;
   663	
   664		/* Clear Rows and Cols */
   665		val = FIELD_PREP(SWRM_MCP_FRAME_CTRL_BANK_ROW_CTRL_BMSK, ctrl->rows_index);
   666		val |= FIELD_PREP(SWRM_MCP_FRAME_CTRL_BANK_COL_CTRL_BMSK, ctrl->cols_index);
   667	
 > 668		if (data->sw_clk_gate_required)
   669			reset_control_reset(ctrl->audio_cgcr);
   670	
   671		ctrl->reg_write(ctrl, SWRM_MCP_FRAME_CTRL_BANK_ADDR(0), val);
   672	
   673		/* Enable Auto enumeration */
   674		ctrl->reg_write(ctrl, SWRM_ENUMERATOR_CFG_ADDR, 1);
   675	
   676		ctrl->intr_mask = SWRM_INTERRUPT_STATUS_RMSK;
   677		/* Mask soundwire interrupts */
   678		ctrl->reg_write(ctrl, SWRM_INTERRUPT_MASK_ADDR,
   679				SWRM_INTERRUPT_STATUS_RMSK);
   680	
   681		/* Configure No pings */
   682		ctrl->reg_read(ctrl, SWRM_MCP_CFG_ADDR, &val);
   683		u32p_replace_bits(&val, SWRM_DEF_CMD_NO_PINGS, SWRM_MCP_CFG_MAX_NUM_OF_CMD_NO_PINGS_BMSK);
   684		ctrl->reg_write(ctrl, SWRM_MCP_CFG_ADDR, val);
   685	
   686		ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL, SWRM_MCP_BUS_CLK_START);
   687		/* Configure number of retries of a read/write cmd */
   688		if (ctrl->version > 0x01050001) {
   689			/* Only for versions >= 1.5.1 */
   690			ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR,
   691					SWRM_RD_WR_CMD_RETRIES |
   692					SWRM_CONTINUE_EXEC_ON_CMD_IGNORE);
   693		} else {
   694			ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR,
   695					SWRM_RD_WR_CMD_RETRIES);
   696		}
   697	
   698		/* Set IRQ to PULSE */
   699		ctrl->reg_write(ctrl, SWRM_COMP_CFG_ADDR,
   700				SWRM_COMP_CFG_IRQ_LEVEL_OR_PULSE_MSK |
   701				SWRM_COMP_CFG_ENABLE_MSK);
   702	
   703		/* enable CPU IRQs */
   704		if (ctrl->mmio) {
   705			ctrl->reg_write(ctrl, SWRM_INTERRUPT_CPU_EN,
   706					SWRM_INTERRUPT_STATUS_RMSK);
   707		}
   708		ctrl->slave_status = 0;
   709		ctrl->reg_read(ctrl, SWRM_COMP_PARAMS, &val);
   710		ctrl->rd_fifo_depth = FIELD_GET(SWRM_COMP_PARAMS_RD_FIFO_DEPTH, val);
   711		ctrl->wr_fifo_depth = FIELD_GET(SWRM_COMP_PARAMS_WR_FIFO_DEPTH, val);
   712	
   713		return 0;
   714	}
   715	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp