linux-kernel - Re: [kbuild-all] Re: [linux-next:master 728/1207] fs/xfs/xfs_file.c:1266:31: sparse: sparse: incorrect type in return expression (different base types)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Jun 2022 11:49:53 +0800
From:   Philip Li <philip.li@...el.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     kernel test robot <lkp@...el.com>,
        Shiyang Ruan <ruansy.fnst@...itsu.com>,
        kbuild-all@...ts.01.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        "Darrick J. Wong" <djwong@...nel.org>, linux-xfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [kbuild-all] Re: [linux-next:master 728/1207]
 fs/xfs/xfs_file.c:1266:31: sparse: sparse: incorrect type in return
 expression (different base types)

On Tue, Jun 07, 2022 at 04:05:46PM -0700, Andrew Morton wrote:
> On Tue, 7 Jun 2022 15:09:18 +0800 kernel test robot <lkp@...el.com> wrote:
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   73d0e32571a0786151eb72634f1a4c5891166176
> > commit: d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c [728/1207] xfs: support CoW in fsdax mode
> > config: x86_64-rhel-8.3-kselftests (https://download.01.org/0day-ci/archive/20220607/202206071511.FI7WLdZo-lkp@intel.com/config)
> > compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
> > reproduce:
> >         # apt-get install sparse
> >         # sparse version: v0.6.4-18-g56afb504-dirty
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout d5f5b32dee7c09e3152cbbce45c73f0b1ea7d94c
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/xfs/
> > 
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@...el.com>
> > 
> > 
> > sparse warnings: (new ones prefixed by >>)
> > >> fs/xfs/xfs_file.c:1266:31: sparse: sparse: incorrect type in return expression (different base types) @@     expected int @@     got restricted vm_fault_t @@
> >    fs/xfs/xfs_file.c:1266:31: sparse:     expected int
> >    fs/xfs/xfs_file.c:1266:31: sparse:     got restricted vm_fault_t
> > >> fs/xfs/xfs_file.c:1260:1: sparse: sparse: symbol 'xfs_dax_fault' was not declared. Should it be static?
> > >> fs/xfs/xfs_file.c:1314:21: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted vm_fault_t [usertype] ret @@     got int @@
> >    fs/xfs/xfs_file.c:1314:21: sparse:     expected restricted vm_fault_t [usertype] ret
> >    fs/xfs/xfs_file.c:1314:21: sparse:     got int
> > 
> > Please review and possibly fold the followup patch.
> 
> Well yes, the followup patch
> (https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/xfs-support-cow-in-fsdax-mode-fix.patch)
> will most definitely be folded.

Sorry, currently we disable the auto patch, this sentence "Please review and possibly fold the followup patch"
is misleading. We will not have follow up patch before we can have human to
do a check.

> 
> Can you suggest how this can be communicated to the robot in order to
> suppress this notification?  A Fixes: won't work, as neither of these
> patches have yet been promoted to a "stable" state.  Their hashes will
> change.

Got it, we also think the Fixes tag in the proposed patch brings confusion
if the "bad" commit is in development state. So far, we haven't exposed a
way to feedback the "Fixes: won't work", but we will work on some level
of mail based communication in 2nd half this year, which can simplify the
communication like this.

Anyway, we now disable the auto patch to avoid bring confusion and sometimes
wrong patch without human check.

> _______________________________________________
> kbuild-all mailing list -- kbuild-all@...ts.01.org
> To unsubscribe send an email to kbuild-all-leave@...ts.01.org