linux-kernel - Re: [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jun 2022 12:11:48 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Yupeng Li <liyupeng@...los.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Jean Delvare <jdelvare@...e.com>,
        "open list:MIPS" <linux-mips@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-hwmon@...r.kernel.org,
        caizp2008@....com
Subject: Re: [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as
 module build error.

Reviewed-by: Huacai Chen <chenhuacai@...nel.org>

On Wed, Jun 8, 2022 at 9:41 AM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On 6/7/22 18:12, Yupeng Li wrote:
> >    set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
> >    undefined error,fix cpu_hwmon compile options to be bool.Some kernel
> >    compilation error information is as follows:
> >
> >    Checking missing-syscalls for N32
> >    CALL    scripts/checksyscalls.sh
> >    Checking missing-syscalls for O32
> >    CALL    scripts/checksyscalls.sh
> >    CALL    scripts/checksyscalls.sh
> >    CHK     include/generated/compile.h
> >    CC [M]  drivers/platform/mips/cpu_hwmon.o
> >    Building modules, stage 2.
> >    MODPOST 200 modules
> > ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> > ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> > make[1]: *** [scripts/Makefile.modpost:92：__modpost] 错误 1
> > make: *** [Makefile:1261：modules] 错误 2
> >
> > Signed-off-by: Yupeng Li <liyupeng@...los.com>
>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
>
> > ---
> >   drivers/platform/mips/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> > index d421e1482395..6b51ad01f791 100644
> > --- a/drivers/platform/mips/Kconfig
> > +++ b/drivers/platform/mips/Kconfig
> > @@ -17,7 +17,7 @@ menuconfig MIPS_PLATFORM_DEVICES
> >   if MIPS_PLATFORM_DEVICES
> >
> >   config CPU_HWMON
> > -     tristate "Loongson-3 CPU HWMon Driver"
> > +     bool "Loongson-3 CPU HWMon Driver"
> >       depends on MACH_LOONGSON64
> >       select HWMON
> >       default y
>