linux-kernel - Re: [PATCH 02/36] tty/vt: consolemap: rename and document struct uni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83fb92d0-7006-a488-1ba2-490ade9b2604@kernel.org>
Date:   Wed, 8 Jun 2022 07:42:17 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/36] tty/vt: consolemap: rename and document struct
 uni_pagedir

On 07. 06. 22, 14:36, Ilpo Järvinen wrote:
> On Tue, 7 Jun 2022, Jiri Slaby wrote:
> 
>> struct uni_pagedir contains 32 unicode page directories, so the name of
>> the structure is a bit misleading. Rename the structure to uni_pagedict,
>> so it looks like this:
>> struct uni_pagedict
>>    -> 32 page dirs
>>       -> 32 rows
>>         -> 64 glyphs
>>
>> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
>> ---
> 
> The rename looks incomplete:
> 
>>   drivers/tty/vt/consolemap.c    | 47 ++++++++++++++++++++--------------
>>   drivers/video/console/vgacon.c |  4 +--
>>   include/linux/console_struct.h |  6 ++---
>>   3 files changed, 33 insertions(+), 24 deletions(-)
> 
> vs
> 
> $ git grep -l vc_uni_pagedir
> drivers/tty/vt/consolemap.c
> drivers/tty/vt/vt.c
> drivers/usb/misc/sisusbvga/sisusb_con.c
> drivers/video/console/vgacon.c
> drivers/video/fbdev/core/fbcon.c
> include/linux/console_struct.h

I renamed only the type, not the variables/members. Maybe the latter 
makes sense too. I will do that as a follow-up patch.

thanks,
-- 
js
suse labs