linux-kernel - Re: [PATCH] pwm: atmel-tcb: use 'unsigned int' instead of 'unsigned'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Jun 2022 08:45:10 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Jilin Yuan <yuanjilin@...rlc.com>
Cc:     thierry.reding@...il.com, lee.jones@...aro.org,
        nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
        claudiu.beznea@...rochip.com, linux-pwm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: atmel-tcb: use 'unsigned int' instead of 'unsigned'

On Wed, Jun 08, 2022 at 09:06:07AM +0800, Jilin Yuan wrote:
> Replace the 'unsigned' with 'unsigned int' which is more accurate.

What was your motivation? To please checkpatch? Please mention this in
the commit log.

> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>
> ---
>  drivers/pwm/pwm-atmel-tcb.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
> index 3977a0f9d132..d6977e4e71f3 100644
> --- a/drivers/pwm/pwm-atmel-tcb.c
> +++ b/drivers/pwm/pwm-atmel-tcb.c
> @@ -35,9 +35,9 @@
>  
>  struct atmel_tcb_pwm_device {
>  	enum pwm_polarity polarity;	/* PWM polarity */
> -	unsigned div;			/* PWM clock divider */
> -	unsigned duty;			/* PWM duty expressed in clk cycles */
> -	unsigned period;		/* PWM period expressed in clk cycles */
> +	unsigned int div;			/* PWM clock divider */
> +	unsigned int duty;			/* PWM duty expressed in clk cycles */
> +	unsigned int period;		/* PWM period expressed in clk cycles */

Please reindent the comments such they keep to be aligned.

>  };
>  
>  struct atmel_tcb_channel {

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)