lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20220608065131.svkxcwfgzdd7cs57@pengutronix.de>
Date:   Wed, 8 Jun 2022 08:51:31 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Jilin Yuan <yuanjilin@...rlc.com>
Cc:     thierry.reding@...il.com, lee.jones@...aro.org,
        mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
        linux-pwm@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: stmpe: Deleted extra {}

On Wed, Jun 08, 2022 at 09:03:18AM +0800, Jilin Yuan wrote:
> Remove unnecessary braces
> 
> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>
> ---
>  drivers/pwm/pwm-stmpe.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-stmpe.c b/drivers/pwm/pwm-stmpe.c
> index 2df526fe9c38..c45fe27859de 100644
> --- a/drivers/pwm/pwm-stmpe.c
> +++ b/drivers/pwm/pwm-stmpe.c
> @@ -78,10 +78,9 @@ static void stmpe_24xx_pwm_disable(struct pwm_chip *chip,
>  	value = ret & ~BIT(pwm->hwpwm);
>  
>  	ret = stmpe_reg_write(stmpe_pwm->stmpe, STMPE24XX_PWMCS, value);
> -	if (ret) {
> +	if (ret)
>  		dev_err(chip->dev, "error writing PWM#%u control\n",
>  			pwm->hwpwm);
> -	}
>  }

This doesn't apply to neither next nor on the pwm tree nor on Linus
Torvald's tree. Please always mention preconditions of your patches,
preferably using git format-patch's --base option.

In this case it builds on top of a patch that was sent to only some
maintainers, but no public list. Please squash these patches together
and send them to (at least) linux-pwm@...r.kernel.org.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ