linux-kernel - Re: [PATCH 2/3] platform/chrome: cros_ec_proto: Rename cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqBTeogFDW1tqfZp@google.com>
Date:   Wed, 8 Jun 2022 08:44:58 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Prashant Malani <pmalani@...omium.org>
Cc:     linux-kernel@...r.kernel.org, bleung@...omium.org,
        Stephen Boyd <swboyd@...omium.org>,
        Brian Norris <briannorris@...omium.org>,
        "open list:CHROME HARDWARE PLATFORM SUPPORT" 
        <chrome-platform@...ts.linux.dev>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Tzung-Bi Shih <tzungbi@...nel.org>
Subject: Re: [PATCH 2/3] platform/chrome: cros_ec_proto: Rename
 cros_ec_command function

On Mon, 06 Jun 2022, Prashant Malani wrote:

> cros_ec_command() is the name of a function as well as a struct, as such
> it can confuse indexing tools (like ctags). Avoid this by renaming it to
> cros_ec_cmd(). Update all the callsites to use the new name.
> 
> This patch is a find-and-replace, so should not introduce any functional
> changes.
> 
> Suggested-by: Stephen Boyd <swboyd@...omium.org>
> Signed-off-by: Prashant Malani <pmalani@...omium.org>
> ---
>  drivers/mfd/cros_ec_dev.c                   |  4 +--

Acked-by: Lee Jones <lee.jones@...aro.org>

>  drivers/platform/chrome/cros_ec_proto.c     | 22 ++++++------
>  drivers/platform/chrome/cros_ec_typec.c     | 39 ++++++++++-----------
>  drivers/platform/chrome/cros_usbpd_notify.c |  4 +--
>  drivers/regulator/cros-ec-regulator.c       | 24 ++++++-------
>  include/linux/platform_data/cros_ec_proto.h |  2 +-
>  6 files changed, 47 insertions(+), 48 deletions(-)

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog