linux-kernel - Re: 5.19-rc1 x86 build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5e11680-9101-24ec-0977-c5d0ff8c98c2@citrix.com>
Date:   Wed, 8 Jun 2022 09:24:25 +0000
From:   Andrew Cooper <Andrew.Cooper3@...rix.com>
To:     Josh Poimboeuf <jpoimboe@...nel.org>
CC:     Joe Damato <jdamato@...tly.com>, "x86@...nel.org" <x86@...nel.org>,
        "jpoimboe@...hat.com" <jpoimboe@...hat.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jiangshanlai@...il.com" <jiangshanlai@...il.com>,
        "bp@...e.de" <bp@...e.de>, "brgerst@...il.com" <brgerst@...il.com>,
        Andrew Cooper <Andrew.Cooper3@...rix.com>
Subject: Re: 5.19-rc1 x86 build failure

On 08/06/2022 01:59, Josh Poimboeuf wrote:
> @@ -133,12 +125,16 @@ asmlinkage void __init x86_64_start_reservations(char *real_mode_data);
>  
>  #endif /* __i386__ */
>  #endif /* _SETUP */
> -#else
> -#define RESERVE_BRK(name,sz)				\
> -	.pushsection .brk_reservation,"aw",@nobits;	\
> -.brk.name:						\
> -1:	.skip sz;					\
> -	.size .brk.name,.-1b;				\
> +
> +#else  /* __ASSEMBLY */
> +
> +#define RESERVE_BRK(name, size)				\
> +	.pushsection .brk_reservation, "aw";		\
> +__brk_##name:						\
> +1:	.skip size;					\
> +	.size __brk_##name, . - 1b;			\
>  	.popsection

While I think about it before you write the patch properly, you ought to
have a .type in here too, seeing as the C side now gets one.

~Andrew