linux-kernel - Re: [PATCH] random: remove rng_has_arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YqBu73Buvna+hROC@alley>
Date:   Wed, 8 Jun 2022 11:42:07 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] random: remove rng_has_arch_random()

On Wed 2022-06-08 10:34:59, Jason A. Donenfeld wrote:
> With arch randomness being used by every distro and enabled in
> defconfigs, the distinction between rng_has_arch_random() and
> rng_is_initialized() is now rather small. In fact, the places where they
> differ are now places where paranoid users and system builders really
> don't want arch randomness to be used, in which case we should respect
> that choice, or places where arch randomness is known to be broken, in
> which case that choice is all the more important. So this commit just
> removes the function and its one user.
> 
> Cc: Petr Mladek <pmladek@...e.com>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

I am not expert on random numbers but it sounds reasonable.
Anyway, the change in vsprintf.c looks good:

Reviewed-by: Petr Mladek <pmladek@...e.com>    # vsprintf.c

Best Regards,
Petr