linux-kernel - Re: [PATCH] virtio-rng: make device ready before making request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8733913f-b04b-f2c7-d7e2-d22740ab99af@redhat.com>
Date:   Wed, 8 Jun 2022 14:17:43 +0200
From:   Laurent Vivier <lvivier@...hat.com>
To:     Jason Wang <jasowang@...hat.com>, mst@...hat.com, mpm@...enic.com,
        herbert@...dor.apana.org.au
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+5b59d6d459306a556f54@...kaller.appspotmail.com
Subject: Re: [PATCH] virtio-rng: make device ready before making request

On 08/06/2022 08:14, Jason Wang wrote:
> Current virtio-rng does a entropy request before DRIVER_OK, this
> violates the spec and kernel will ignore the interrupt after commit
> 8b4ec69d7e09 ("virtio: harden vring IRQ").
> 
> Fixing this by making device ready before the request.
> 
> Fixes: 8b4ec69d7e09 ("virtio: harden vring IRQ")
> Reported-and-tested-by: syzbot+5b59d6d459306a556f54@...kaller.appspotmail.com
> Signed-off-by: Jason Wang <jasowang@...hat.com>
> ---
>   drivers/char/hw_random/virtio-rng.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/char/hw_random/virtio-rng.c b/drivers/char/hw_random/virtio-rng.c
> index e856df7e285c..a6f3a8a2aca6 100644
> --- a/drivers/char/hw_random/virtio-rng.c
> +++ b/drivers/char/hw_random/virtio-rng.c
> @@ -159,6 +159,8 @@ static int probe_common(struct virtio_device *vdev)
>   		goto err_find;
>   	}
>   
> +	virtio_device_ready(vdev);
> +
>   	/* we always have a pending entropy request */
>   	request_entropy(vi);
>   

Reviewed-by: Laurent Vivier <lvivier@...hat.com>