[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220608135116.GA27854@asgard.redhat.com>
Date: Wed, 8 Jun 2022 15:52:54 +0200
From: Eugene Syromiatnikov <esyr@...hat.com>
To: Andrew Davis <afd@...com>
Cc: Jens Wiklander <jens.wiklander@...aro.org>,
Sumit Garg <sumit.garg@...aro.org>,
op-tee@...ts.trustedfirmware.org, linux-kernel@...r.kernel.org,
ldv@...ace.io
Subject: Re: [PATCH v2 2/2] tee: remove flags TEE_IOCTL_SHM_MAPPED and
TEE_IOCTL_SHM_DMA_BUF
On Mon, Apr 25, 2022 at 09:16:17AM -0500, Andrew Davis wrote:
> These look to be leftover from an early edition of this driver. Userspace
> does not need this information. Checking all users of this that I have
> access to I have verified no one is using them.
This change has broken build of strace's test suite against the latest kernel
headers[1]; the usage prety much shows up in the Debian's code search[2].
[1] https://github.com/strace/strace/runs/6794205205?check_suite_focus=true#step:4:3862
[2] https://codesearch.debian.net/search?q=TEE_IOCTL_SHM_MAPPED+package%3A%5CQstrace%5CE&literal=1
> They leak internal use flags out to userspace. Even more they are not
> correct anymore after a45ea4efa358. Lets drop these flags before
> someone does try to use them for something and they become ABI.
Powered by blists - more mailing lists