linux-kernel - Re: [PATCH v2 2/3] usb: phy: Add devm_of_usb_get_phy_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Jun 2022 20:00:30 +0530
From:   Harsh Agarwal <quic_harshq@...cinc.com>
To:     Sergey Shtylyov <s.shtylyov@....ru>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Felipe Balbi <balbi@...nel.org>,
        "Bjorn Andersson" <bjorn.andersson@...aro.org>
CC:     <linux-usb@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_pkondeti@...cinc.com>,
        <quic_ppratap@...cinc.com>, <quic_jackp@...cinc.com>,
        <ahalaney@...hat.com>
Subject: Re: [PATCH v2 2/3] usb: phy: Add devm_of_usb_get_phy_by_phandle


On 6/6/2022 4:30 PM, Sergey Shtylyov wrote:
> Hello!
>
> On 6/3/22 8:12 PM, Harsh Agarwal wrote:
>
>> Adding support for devm_of_usb_get_phy_by_phandle which allows
>> us to get PHY phandles of a device declared inside lookup_node.
>>
>> Signed-off-by: Harsh Agarwal <quic_harshq@...cinc.com>
> [...]
>> diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h
>> index e4de6bc..2581c72 100644
>> --- a/include/linux/usb/phy.h
>> +++ b/include/linux/usb/phy.h
> [...]
>> @@ -249,6 +251,12 @@ static inline struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev,
>>   	return ERR_PTR(-ENXIO);
>>   }
>>   
>> +extern inline struct usb_phy *devm_of_usb_get_phy_by_phandle(struct device *dev,
>     *extern inline*? :-O
>     Shouldn't it be *static*?
This was a typo. Will change it. Thanks
>   
>> +	const char *phandle, u8 index, struct device_node *lookup_node)
>> +{
>> +	return ERR_PTR(-ENXIO);
>> +}
>> +
>>   static inline struct usb_phy *devm_usb_get_phy_by_node(struct device *dev,
>>   	struct device_node *node, struct notifier_block *nb)
>>   {
> MBR, Sergey