linux-kernel - Re: [PATCH v2 049/144] KVM: selftests: Return the created vCPU from vm_vcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jun 2022 17:22:12 +0200
From:   Andrew Jones <drjones@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        David Matlack <dmatlack@...gle.com>,
        Ben Gardon <bgardon@...gle.com>,
        Oliver Upton <oupton@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 049/144] KVM: selftests: Return the created vCPU from
 vm_vcpu_add()

On Fri, Jun 03, 2022 at 12:41:56AM +0000, Sean Christopherson wrote:
> Return the created vCPU from vm_vcpu_add() so that callers don't need to
> manually retrieve the vCPU that was just added.  Opportunistically drop
> the "heavy" function comment, it adds a lot of lines of "code" but not
> much value, e.g. it's pretty obvious that @vm is a virtual machine...

I agree and would like to see all the heavy function comments reduced.
Maybe you do that somewhere in next 100 patches :-)

Thanks,
drew