linux-kernel - Re: [PATCH 03/10] ext4: Convert mpage_release_unused_pages() to use filemap_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqDIIH2d7iu1o7D0@casper.infradead.org>
Date:   Wed, 8 Jun 2022 17:02:40 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
        linux-mm@...ck.org, linux-nilfs@...r.kernel.org
Subject: Re: [PATCH 03/10] ext4: Convert mpage_release_unused_pages() to use
 filemap_get_folios()

On Wed, Jun 08, 2022 at 01:02:22AM -0700, Christoph Hellwig wrote:
> On Sun, Jun 05, 2022 at 08:38:47PM +0100, Matthew Wilcox (Oracle) wrote:
> > If the folio is large, it may overlap the beginning or end of the
> > unused range.  If it does, we need to avoid invalidating it.
> 
> It's never going to be larger for ext4, is it?  But either way,
> those precautions looks fine.

I don't want to say "never".  Today, it's not, but if ext4 ever does
gain support for large folios, then this is a precaution it will need
to take.  I'm trying not to leave traps when I do conversions.

> Reviewed-by: Christoph Hellwig <hch@....de>