[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YqDVW81B1q0EXkfh@google.com>
Date: Wed, 8 Jun 2022 16:59:07 +0000
From: David Matlack <dmatlack@...gle.com>
To: Lai Jiangshan <jiangshanlai@...il.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
Paolo Bonzini <pbonzini@...hat.com>,
Sean Christopherson <seanjc@...gle.com>,
Vitaly Kuznetsov <vkuznets@...hat.com>,
Maxim Levitsky <mlevitsk@...hat.com>,
Lai Jiangshan <jiangshan.ljs@...group.com>
Subject: Re: [PATCH 0/6] KVM: Trivial cleanups
On Sun, Jun 05, 2022 at 02:34:11PM +0800, Lai Jiangshan wrote:
> From: Lai Jiangshan <jiangshan.ljs@...group.com>
>
> A small collection of trivial cleanups.
Nice cleanups. My only feedback is on the commit messages, which are a
bit terse. Here's what I would recommend:
- Explain what the commit does in the first sentence/paragraph of the
commit message and then explain why/background info.
- Include "No functional change intended." for commits that are
expected to be no-ops. It's pretty obvious for most of these changes
but it's still nice that have to convey your intent.
Commit messages aside:
Reviewed-by: David Matlack <dmatlack@...gle.com>
>
> Lai Jiangshan (6):
> KVM: X86/MMU: Remove unused macros from paging_tmpl.h
> KVM: X86/MMU: Remove unused PT32_DIR_BASE_ADDR_MASK from mmu.c
> KVM: X86/MMU: Update comments in paging_tmpl.h for the kinds of guest
> PTEs
> KVM: Rename ack_flush() to ack_kick()
> KVM: X86/MMU: Remove useless mmu_topup_memory_caches() in
> kvm_mmu_pte_write()
> KVM: X86/SVM: Use root_level in svm_load_mmu_pgd()
>
> arch/x86/kvm/mmu/mmu.c | 9 ---------
> arch/x86/kvm/mmu/paging_tmpl.h | 16 ++--------------
> arch/x86/kvm/svm/svm.c | 2 +-
> virt/kvm/kvm_main.c | 4 ++--
> 4 files changed, 5 insertions(+), 26 deletions(-)
>
> --
> 2.19.1.6.gb485710b
>
Powered by blists - more mailing lists