linux-kernel - Re: [PATCH v4 3/4] fat: add renameat2 RENAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18d9e587-b4f7-6ee7-185a-af0e667e0ec5@redhat.com>
Date:   Wed, 8 Jun 2022 20:21:26 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:     linux-kernel@...r.kernel.org,
        Lennart Poettering <lennart@...ttering.net>,
        Colin Walters <walters@...bum.org>,
        Peter Jones <pjones@...hat.com>,
        Alberto Ruiz <aruiz@...hat.com>,
        Christian Kellner <ckellner@...hat.com>,
        Chung-Chiang Cheng <cccheng@...ology.com>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Alexander Larsson <alexl@...hat.com>
Subject: Re: [PATCH v4 3/4] fat: add renameat2 RENAME_EXCHANGE flag support

On 6/8/22 19:10, OGAWA Hirofumi wrote:
> Javier Martinez Canillas <javierm@...hat.com> writes:
> 

[snip]

>>> Probably, we should change the nlink only if both of dotdot update are
>>> succeed and different file type. Otherwise, we would have to revert the
>>> nlink change on error path (and can remove unnecessary update as bonus).
>>>
>>
>> Agreed. I'll wait a few days before posting v5 in case you have more
>> comments on the other patches.
> 
> Ok. I have no comment other than this at least for now (reviewed all
> patches). If I found more on re-review I will send email.
>

Perfect, thanks! If you reviewed all the patches already then I'll send
the v6 tomorrow.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat