[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <df2333e1-fae0-3e9a-2b47-3ac26c583876@gmail.com>
Date: Wed, 8 Jun 2022 21:47:24 +0300
From: Péter Ujfalusi <peter.ujfalusi@...il.com>
To: Miaoqian Lin <linmq006@...il.com>, Vinod Koul <vkoul@...nel.org>,
dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dmaengine: ti: Add missing put_device in
ti_dra7_xbar_route_allocate
On 05/06/2022 07:27, Miaoqian Lin wrote:
> of_find_device_by_node() takes reference, we should use put_device()
> to release it when not need anymore.
Thank you for the update!
For both:
Acked-by: Peter Ujfalusi <peter.ujfalusi@...il.com>
>
> Fixes: a074ae38f859 ("dmaengine: Add driver for TI DMA crossbar on DRA7x")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
> changes in v3:
> - rebase so it can apply with the other patch
> changes in v2:
> - split v1 into two patches.
> v1 link:
> https://lore.kernel.org/r/20220512051815.11946-1-linmq006@gmail.com
> v2 link:
> https://lore.kernel.org/r/20220601110013.55366-1-linmq006@gmail.com/
> ---
> drivers/dma/ti/dma-crossbar.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> index e34cfb50d241..f744ddbbbad7 100644
> --- a/drivers/dma/ti/dma-crossbar.c
> +++ b/drivers/dma/ti/dma-crossbar.c
> @@ -245,6 +245,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
> if (dma_spec->args[0] >= xbar->xbar_requests) {
> dev_err(&pdev->dev, "Invalid XBAR request number: %d\n",
> dma_spec->args[0]);
> + put_device(&pdev->dev);
> return ERR_PTR(-EINVAL);
> }
>
> @@ -252,12 +253,14 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
> dma_spec->np = of_parse_phandle(ofdma->of_node, "dma-masters", 0);
> if (!dma_spec->np) {
> dev_err(&pdev->dev, "Can't get DMA master\n");
> + put_device(&pdev->dev);
> return ERR_PTR(-EINVAL);
> }
>
> map = kzalloc(sizeof(*map), GFP_KERNEL);
> if (!map) {
> of_node_put(dma_spec->np);
> + put_device(&pdev->dev);
> return ERR_PTR(-ENOMEM);
> }
>
> @@ -269,6 +272,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
> dev_err(&pdev->dev, "Run out of free DMA requests\n");
> kfree(map);
> of_node_put(dma_spec->np);
> + put_device(&pdev->dev);
> return ERR_PTR(-ENOMEM);
> }
> set_bit(map->xbar_out, xbar->dma_inuse);
--
Péter
Powered by blists - more mailing lists