lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Jun 2022 19:49:30 +0000 From: Sean Christopherson <seanjc@...gle.com> To: Andrew Jones <drjones@...hat.com> Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org, Vitaly Kuznetsov <vkuznets@...hat.com>, David Matlack <dmatlack@...gle.com>, Ben Gardon <bgardon@...gle.com>, Oliver Upton <oupton@...gle.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 038/144] KVM: selftests: Push vm_adjust_num_guest_pages() into "w/o vCPUs" helper On Wed, Jun 08, 2022, Andrew Jones wrote: > On Fri, Jun 03, 2022 at 12:41:45AM +0000, Sean Christopherson wrote: > > Move the call to vm_adjust_num_guest_pages() from vm_create_with_vcpus() > > down into vm_create_without_vcpus(). This will allow a future patch to > > make the "w/o vCPUs" variant the common inner helper, e.g. so that the > > "with_vcpus" helper calls the "without_vcpus" helper, instead of having > > them be separate paths. > > > > Signed-off-by: Sean Christopherson <seanjc@...gle.com> > > --- > > tools/testing/selftests/kvm/lib/kvm_util.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > > index 1c5caf2ddca4..6b0b65c26d4d 100644 > > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > > @@ -282,6 +282,8 @@ struct kvm_vm *vm_create_without_vcpus(enum vm_guest_mode mode, uint64_t pages) > > { > > struct kvm_vm *vm; > > > > + pages = vm_adjust_num_guest_pages(VM_MODE_DEFAULT, pages); > > Hi Sean, > > We should pass 'mode' here. Ouch. Very nice catch! Lucky for me, the resulting conflicts later in the series are obvious and straightfoward. Thanks much!
Powered by blists - more mailing lists