lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Jun 2022 15:25:57 -0500 From: Bjorn Helgaas <helgaas@...nel.org> To: Miaoqian Lin <linmq006@...il.com> Cc: Nicolas Saenz Julienne <nsaenz@...nel.org>, Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Jim Quinlan <jim2101024@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Rob Herring <robh@...nel.org>, Krzysztof WilczyĆski <kw@...ux.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Marc Zyngier <maz@...nel.org>, Andrew Murray <amurray@...goodpenguin.co.uk>, linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] PCI: brcmstb: Fix refcount leak in brcm_pcie_probe On Fri, Jun 03, 2022 at 05:08:49PM +0400, Miaoqian Lin wrote: > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 40ca1bf580ef ("PCI: brcmstb: Add MSI support") > Signed-off-by: Miaoqian Lin <linmq006@...il.com> Applied with Rob's reviewed-by to pci/ctrl/brcmstb for v5.20, thanks! > --- > changes in v2: > - update Fixes tag. > v1 Link: https://lore.kernel.org/r/20220602125003.10723-1-linmq006@gmail.com > --- > drivers/pci/controller/pcie-brcmstb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c > index 375c0c40bbf8..e3b673441a11 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -1597,8 +1597,10 @@ static int brcm_pcie_probe(struct platform_device *pdev) > ret = brcm_pcie_enable_msi(pcie); > if (ret) { > dev_err(pcie->dev, "probe of internal MSI failed"); > + of_node_put(msi_np); > goto fail; > } > + of_node_put(msi_np); > } > > bridge->ops = pcie->type == BCM7425 ? &brcm_pcie_ops32 : &brcm_pcie_ops; > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@...ts.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Powered by blists - more mailing lists