[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202206090531.0eWVAe0k-lkp@intel.com>
Date: Thu, 9 Jun 2022 05:59:00 +0800
From: kernel test robot <lkp@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: kbuild-all@...ts.01.org,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v1 1/1] spi: Replace match_true() by device_match_any()
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on v5.19-rc1 next-20220608]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/spi-Replace-match_true-by-device_match_any/20220608-091910
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20220609/202206090531.0eWVAe0k-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/bbdbed23cc6f2f8e7c9d8da3bb6c78fe488747f1
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/spi-Replace-match_true-by-device_match_any/20220608-091910
git checkout bbdbed23cc6f2f8e7c9d8da3bb6c78fe488747f1
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/spi/spi.c: In function 'slave_show':
>> drivers/spi/spi.c:2670:53: error: passing argument 3 of 'device_find_child' from incompatible pointer type [-Werror=incompatible-pointer-types]
2670 | child = device_find_child(&ctlr->dev, NULL, device_match_any);
| ^~~~~~~~~~~~~~~~
| |
| int (*)(struct device *, const void *)
In file included from drivers/spi/spi.c:8:
include/linux/device.h:905:40: note: expected 'int (*)(struct device *, void *)' but argument is of type 'int (*)(struct device *, const void *)'
905 | int (*match)(struct device *dev, void *data));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/spi/spi.c: In function 'slave_store':
drivers/spi/spi.c:2689:53: error: passing argument 3 of 'device_find_child' from incompatible pointer type [-Werror=incompatible-pointer-types]
2689 | child = device_find_child(&ctlr->dev, NULL, device_match_any);
| ^~~~~~~~~~~~~~~~
| |
| int (*)(struct device *, const void *)
In file included from drivers/spi/spi.c:8:
include/linux/device.h:905:40: note: expected 'int (*)(struct device *, void *)' but argument is of type 'int (*)(struct device *, const void *)'
905 | int (*match)(struct device *dev, void *data));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/device_find_child +2670 drivers/spi/spi.c
2662
2663 static ssize_t slave_show(struct device *dev, struct device_attribute *attr,
2664 char *buf)
2665 {
2666 struct spi_controller *ctlr = container_of(dev, struct spi_controller,
2667 dev);
2668 struct device *child;
2669
> 2670 child = device_find_child(&ctlr->dev, NULL, device_match_any);
2671 return sprintf(buf, "%s\n",
2672 child ? to_spi_device(child)->modalias : NULL);
2673 }
2674
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists