linux-kernel - Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE-0n52aJC_LzT_cYxQXKEpcE58YqCbT7jW0iEaaxtbW9jL4jg@mail.gmail.com>
Date:   Wed, 8 Jun 2022 15:14:54 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        David Heidelberg <david@...t.cz>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Guo Zhengkui <guozhengkui@...o.com>,
        Miaoqian Lin <linmq006@...il.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Rob Clark <robdclark@...il.com>, Rob Herring <robh@...nel.org>,
        Sean Paul <sean@...rly.run>, Xu Wang <vulab@...as.ac.cn>,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/msm/mdp4: Fix refcount leak in mdp4_modeset_init_intf

Quoting Miaoqian Lin (2022-06-07 04:08:38)
> of_graph_get_remote_node() returns remote device node pointer with
> refcount incremented, we should use of_node_put() on it
> when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 86418f90a4c1 ("drm: convert drivers to use of_graph_get_remote_node")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>