linux-kernel - Re: [PATCH v2 net-next 5/8] vmxnet3: add command to set ring buffer sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A1A204A7-87BD-40F5-A2F9-447224285AB9@vmware.com>
Date:   Wed, 8 Jun 2022 23:08:22 +0000
From:   Ronak Doshi <doshir@...are.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Pv-drivers <Pv-drivers@...are.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 5/8] vmxnet3: add command to set ring buffer
 sizes


On 6/7/22, 5:28 PM, "Jakub Kicinski" <kuba@...nel.org> wrote:

>    On Tue, 7 Jun 2022 01:45:15 -0700 Ronak Doshi wrote:
>   > +             adapter->ringBufSize.ring1BufSizeType0 = adapter->skb_buf_size;
>   > +             adapter->ringBufSize.ring1BufSizeType1 = 0;
>   > +             adapter->ringBufSize.ring2BufSizeType1 = PAGE_SIZE;
>
>    These need to use correct byte ordering helpers, since the fields are
>    __le16 probably cpu_to_le16().

Thanks, fixed it and sent revised patches.

Thanks,
Ronak