linux-kernel - Re: [PATCH v3 0/4] staging: r8188eu: add error handling of usb read errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2cdd4ae-f273-0510-9a58-1ed56f456893@gmail.com>
Date:   Tue, 7 Jun 2022 22:04:56 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        straube.linux@...il.com, dan.carpenter@...cle.com,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v3 0/4] staging: r8188eu: add error handling of usb read
 errors

Hi Greg,

On 6/7/22 14:07, Greg KH wrote:
> After applying, I get the following build warning which breaks the
> build:
> 
> drivers/staging/r8188eu/core/rtw_mlme_ext.c:6826:13: error: unused variable ‘res’ [-Werror=unused-variable]
>   6826 |         int res;
>        |             ^~~
> 
> Please test-build your patches before sending them out :(
> 

Was curious about why my compiler didn't yell at me about that issue, 
since I've done not only build test, but also tested on real hw...

Build failure occurs while applying 1/4, but 3/4 fixes it, that's why I 
missed that build error

Anyway, it's only my bad. Sorry about that, will fix up in next version.




With regards,
Pavel Skripkin

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)