linux-kernel - Re: [PATCH] sh: cast away __iomem to remove sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c24579a3-74e4-1dbb-6237-d9e1a01e6e09@landley.net>
Date:   Tue, 7 Jun 2022 17:56:22 -0500
From:   Rob Landley <rob@...dley.net>
To:     Baoquan He <bhe@...hat.com>, ysato@...rs.sourceforge.jp,
        dalias@...c.org
Cc:     linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] sh: cast away __iomem to remove sparse warning



On 5/30/22 07:09, Baoquan He wrote:
> Hi,
> 
> On 05/07/22 at 09:34am, Baoquan He wrote:
>> LKP reported a sparse warning in arch/sh/kernel/crash_dump.c during
>> a kdump patchset reviewing:
>> https://lore.kernel.org/all/202204082128.JKXXDGpa-lkp@intel.com/T/#u
>> 
>> ../arch/sh/kernel/crash_dump.c:23:36: sparse: warning: incorrect type in argument 1 (different address spaces)
>> ../arch/sh/kernel/crash_dump.c:23:36: sparse:    expected void const *addr
>> ../arch/sh/kernel/crash_dump.c:23:36: sparse:    got void [noderef] __iomem *
>> 
>> This warning happened when __iomem pointer is passed into fucntion
>> which doesn't expect it. Casting away the __iomem can fix it.
> 
> This warning was reported by lkp during one patchset posted and
> reviewing. Since it's not related to the patchset, I just sent it
> separately so that later code change on arch/sh/kernel/crash_dump.c
> won't trigger the lkp warning again.
> 
> [PATCH v5 RESEND 0/3] Convert vmcore to use an iov_iter
> https://lore.kernel.org/all/20220408090636.560886-2-bhe@redhat.com/T/#u
> 
> Now the above patchset has been merged into linus's tree, please
> consider taking this patch.
> 
> Thanks
> Baoquan
> 
>> 
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Baoquan He <bhe@...hat.com>

Tested-by: Rob Landley <rob@...dley.net>

Rob