[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9077f91b-0e1d-25bc-56a9-66a500e16ff4@linaro.org>
Date: Wed, 8 Jun 2022 01:34:54 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Bjorn Andersson <bjorn.andersson@...aro.org>,
Kishon Vijay Abraham I <kishon@...com>,
Vinod Koul <vkoul@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Manu Gautam <mgautam@...eaurora.org>
Cc: linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/5] phy: qcom: Add SC8280XP UNI and COMBO USB phys
On 08/06/2022 00:35, Bjorn Andersson wrote:
> The Qualcomm SC8280XP has two pairs of USB phys; a pair of combo phys and a
> pair of uni phys. Introduce support for these.
>
> This is based ontop of Dmitry's refactoring of the QMP driver:
> https://lore.kernel.org/all/20220602070909.1666068-1-dmitry.baryshkov@linaro.org/
>
> A first version of this series was posted with only the UNI phy, this fixes a
> few comments and add the combo phy as well.
>
> Bjorn Andersson (5):
> dt-bindings: phy: qcom,qmp: Add compatible for SC8280XP USB phys
> phy: qcom-qmp: Add USB3 5NM QMP UNI registers
> phy: qcom-qmp: Add USB4 5NM QMP combo PHY registers
I've noted, which symbols look close enough to be folded into existing
namespaces. Could you please doublecheck my analysis and merge the tables?
> phy: qcom-qmp: Add SC8280XP USB3 UNI phy
> phy: qcom-qmp: Add sc8280xp USB/DP combo phys
>
> .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 +
> .../bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 1 +
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 205 +++
> drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 138 ++
> drivers/phy/qualcomm/phy-qcom-qmp.h | 13 +
> .../phy/qualcomm/phy-qcom-usb3-5nm-qmp-uni.h | 617 +++++++
> .../qualcomm/phy-qcom-usb4-5nm-qmp-combo.h | 1547 +++++++++++++++++
> 7 files changed, 2523 insertions(+)
> create mode 100644 drivers/phy/qualcomm/phy-qcom-usb3-5nm-qmp-uni.h
> create mode 100644 drivers/phy/qualcomm/phy-qcom-usb4-5nm-qmp-combo.h
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists