linux-kernel - Re: [PATCH -next 1/2] spi: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5575cbe-e0a4-fae6-65e1-6bb4b3b6f5d4@microchip.com>
Date:   Thu, 9 Jun 2022 15:15:34 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <broonie@...nel.org>, <yang.lee@...ux.alibaba.com>
CC:     <Conor.Dooley@...rochip.com>, <Lewis.Hanly@...rochip.com>,
        <linux-riscv@...ts.infradead.org>, <linux-spi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next 1/2] spi: Remove unnecessary print function
 dev_err()

On 09/06/2022 11:55, Mark Brown wrote:
> On Thu, Jun 09, 2022 at 01:55:33PM +0800, Yang Li wrote:
>> The function platform_get_irq() never returns 0, and the print function
>> dev_err() is redundant because platform_get_irq() already prints an error.
> 
> Are you sure it never returns 0?  Note that 0 is a valid IRQ number on
> some architectures.

If anything, I think I need to go in the other direction and make sure
that in my i2c and pwm drivers I also check for zero - it's an FPGA
after all.

Thanks,
Conor.