linux-kernel - Re: [PATCH -next] spi: Return true/false (not 1/0) from bool function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e28c0a30-9d49-f366-9562-f5a254bb4b09@microchip.com>
Date:   Thu, 9 Jun 2022 15:28:10 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <krzysztof.kozlowski@...aro.org>, <yang.lee@...ux.alibaba.com>
CC:     <andi@...zian.org>, <broonie@...nel.org>,
        <alim.akhtar@...sung.com>, <linux-spi@...r.kernel.org>,
        <linux-samsung-soc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] spi: Return true/false (not 1/0) from bool function

On 09/06/2022 07:36, Krzysztof Kozlowski wrote:
> On 09/06/2022 08:03, Yang Li wrote:
>> Return boolean values ("true" or "false") instead of 1 or 0 from bool
>> function. This fixes the following warnings from coccicheck:
>>
>> ./drivers/spi/spi-s3c64xx.c:385:9-10: WARNING: return of 0/1 in function
>> 's3c64xx_spi_can_dma' with return type bool
>>
>> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> 
> It was reported by coccinelle, not robot, wasn't it?
> 
> I cannot find this report. 

Yeah, I was similarly confused by the patches on my driver.
Spent some time digging through quarantine systems etc to
try and find the report & couldn't.

I hope I didn't miss something.

> This is an open source work and public
> collaboration. The "Reported-by" usually means that the issue was
> reported. Usually in public. Can we see the report?
> Otherwise adding non-public reports is useless and clutters our
> report-credit-system.
> 
> 
> 
>> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
>> ---
>>  drivers/spi/spi-s3c64xx.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
>> index 82558e37c735..28e7b7cb68a7 100644
>> --- a/drivers/spi/spi-s3c64xx.c
>> +++ b/drivers/spi/spi-s3c64xx.c
>> @@ -382,7 +382,7 @@ static bool s3c64xx_spi_can_dma(struct spi_master *master,
>>  	if (sdd->rx_dma.ch && sdd->tx_dma.ch) {
>>  		return xfer->len > (FIFO_LVL_MASK(sdd) >> 1) + 1;
>>  	} else {
>> -		return 0;
>> +		return false;
>>  	}
>>  
>>  }
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> 
> Best regards,
> Krzysztof