linux-kernel - RE: [PATCH] Drivers: hv: vmbus: Release cpu lock in error case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Jun 2022 17:39:06 +0000
From:   "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
To:     Saurabh Sengar <ssengar@...ux.microsoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        Dexuan Cui <decui@...rosoft.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Saurabh Singh Sengar <ssengar@...rosoft.com>
Subject: RE: [PATCH] Drivers: hv: vmbus: Release cpu lock in error case

From: Saurabh Sengar <ssengar@...ux.microsoft.com> Sent: Thursday, June 9, 2022 10:17 AM
> 
> In case of invalid sub channel, release cpu lock before returning.
> 
> Signed-off-by: Saurabh Sengar <ssengar@...ux.microsoft.com>
> ---
>  drivers/hv/channel_mgmt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
> index 280b529..5b12040 100644
> --- a/drivers/hv/channel_mgmt.c
> +++ b/drivers/hv/channel_mgmt.c
> @@ -639,6 +639,7 @@ static void vmbus_process_offer(struct vmbus_channel
> *newchannel)
>  		 */
>  		if (newchannel->offermsg.offer.sub_channel_index == 0) {
>  			mutex_unlock(&vmbus_connection.channel_mutex);
> +			cpus_read_unlock();
>  			/*
>  			 * Don't call free_channel(), because newchannel->kobj
>  			 * is not initialized yet.
> --
> 1.8.3.1

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>