linux-kernel - RE: [PATCH] rxe: fix xa_alloc_cycle() error return value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Jun 2022 17:55:22 +0000
From:   "Pearson, Robert B" <robert.pearson2@....com>
To:     Dongliang Mu <dzm91@...t.edu.cn>,
        Zhu Yanjun <zyjzyj2000@...il.com>,
        "Jason Gunthorpe" <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>
CC:     Dongliang Mu <mudongliangabcd@...il.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] rxe: fix xa_alloc_cycle() error return value check

Reviewed-by: Bob Pearson <rpearsonhpe@...il.com>

Thanks Mu.

-----Original Message-----
From: Dongliang Mu <dzm91@...t.edu.cn> 
Sent: Thursday, June 9, 2022 1:43 AM
To: Zhu Yanjun <zyjzyj2000@...il.com>; Jason Gunthorpe <jgg@...pe.ca>; Leon Romanovsky <leon@...nel.org>
Cc: Dongliang Mu <mudongliangabcd@...il.com>; linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: [PATCH] rxe: fix xa_alloc_cycle() error return value check

From: Dongliang Mu <mudongliangabcd@...il.com>

Currently rxe_alloc checks ret to indicate error, but 1 is also a valid return and just indicates that the allocation succeeded with a wrap.

Fix this by modifying the check to be < 0.

Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>
---
 drivers/infiniband/sw/rxe/rxe_pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_pool.c b/drivers/infiniband/sw/rxe/rxe_pool.c
index 19b14826385b..1cc8e847ccff 100644
--- a/drivers/infiniband/sw/rxe/rxe_pool.c
+++ b/drivers/infiniband/sw/rxe/rxe_pool.c
@@ -139,7 +139,7 @@ void *rxe_alloc(struct rxe_pool *pool)
 
 	err = xa_alloc_cyclic(&pool->xa, &elem->index, elem, pool->limit,
 			      &pool->next, GFP_KERNEL);
-	if (err)
+	if (err < 0)
 		goto err_free;
 
 	return obj;
--
2.25.1