linux-kernel - Re: [PATCH v3 2/3] mm: kmemleak: add rbtree and store physical address for objects allocated with PA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Jun 2022 19:10:20 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Patrick Wang <patrick.wang.shcn@...il.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, yee.lee@...iatek.com
Subject: Re: [PATCH v3 2/3] mm: kmemleak: add rbtree and store physical
 address for objects allocated with PA

On Thu, Jun 09, 2022 at 08:49:49PM +0800, Patrick Wang wrote:
> Add object_phys_tree_root to store the objects allocated with
> physical address. Distinguish it from object_tree_root by
> OBJECT_PHYS flag or function argument. The physical address
> is stored directly in those objects. And remove the unused
> kmemleak_not_leak_phys() function.
> 
> Suggested-by: Catalin Marinas <catalin.marinas@....com>
> Signed-off-by: Patrick Wang <patrick.wang.shcn@...il.com>
> ---
>  Documentation/dev-tools/kmemleak.rst |   1 -
>  include/linux/kmemleak.h             |   4 -
>  mm/kmemleak.c                        | 145 +++++++++++++++++----------
>  3 files changed, 91 insertions(+), 59 deletions(-)
> 
> diff --git a/Documentation/dev-tools/kmemleak.rst b/Documentation/dev-tools/kmemleak.rst
> index 1c935f41cd3a..5483fd39ef29 100644
> --- a/Documentation/dev-tools/kmemleak.rst
> +++ b/Documentation/dev-tools/kmemleak.rst
> @@ -174,7 +174,6 @@ mapping:
>  
>  - ``kmemleak_alloc_phys``
>  - ``kmemleak_free_part_phys``
> -- ``kmemleak_not_leak_phys``
>  - ``kmemleak_ignore_phys``

Same comment - only if you respin, move the kmemleak_not_leak_phys()
removal to a separate patch. Otherwise:

Reviewed-by: Catalin Marinas <catalin.marinas@....com>