linux-kernel - Re: [PATCH] certs: Convert spaces in certs/Makefile to a tab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQKRK9e6=ND8o22YtV0mHs4OhH4qE49t4=UDLAgih+uEQ@mail.gmail.com>
Date:   Fri, 10 Jun 2022 03:21:03 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Mickaël Salaün <mic@...ikod.net>
Cc:     David Howells <dhowells@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jarkko Sakkinen <jarkko@...nel.org>, keyrings@...r.kernel.org,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] certs: Convert spaces in certs/Makefile to a tab

On Fri, Jun 10, 2022 at 2:17 AM Mickaël Salaün <mic@...ikod.net> wrote:
>
>
>
> On 09/06/2022 19:12, Mickaël Salaün wrote:
> >
> > On 06/06/2022 18:49, Masahiro Yamada wrote:
> >> On Mon, Jun 6, 2022 at 9:32 PM David Howells <dhowells@...hat.com> wrote:
> >>>
> >>> There's a rule in certs/Makefile for which the command begins with eight
> >>> spaces.  This results in:
> >>>
> >>>          ../certs/Makefile:21: FORCE prerequisite is missing
> >>>          ../certs/Makefile:21: *** missing separator.  Stop.
> >>>
> >>> Fix this by turning the spaces into a tab.
> >>>
> >>> Fixes: addf466389d9 ("certs: Check that builtin blacklist hashes are
> >>> valid")
> >>> Signed-off-by: David Howells <dhowells@...hat.com>
> >>> cc: Mickaël Salaün <mic@...ux.microsoft.com>
> >>> cc: Jarkko Sakkinen <jarkko@...nel.org>
> >>> cc: keyrings@...r.kernel.org
> >>
> >>
> >> Not only 8-space indentation, but also:
> >>
> >>    - config_filename does not exist
> >>    - $(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX) is always empty
> >>    - $(SYSTEM_BLACKLIST_HASH_LIST_FILENAME) is always empty
> >
> > These are imported helpers (not only used for this hash list BTW), hence
> > not defined in this Makefile.
>
> Well, they were defined in scripts/Kbuild.include but they are gone
> since your commit b8c96a6b466c ("certs: simplify $(srctree)/ handling
> and remove config_filename macro").
>
> I guess it just happens during the merge. We need to fix that.
>




Right, it seems your patch was flying for a long time.





$ git show --pretty=fuller   addf466389d9d78f255e8b15ac44ab4791029852
commit addf466389d9d78f255e8b15ac44ab4791029852
Author:     Mickaël Salaün <mic@...ux.microsoft.com>
AuthorDate: Mon Jul 12 19:03:10 2021 +0200
Commit:     Jarkko Sakkinen <jarkko@...nel.org>
CommitDate: Mon May 23 18:47:49 2022 +0300

    certs: Check that builtin blacklist hashes are valid




It was committed 8 months after the patch submission.

The base code changed during the gap.




--
Best Regards
Masahiro Yamada