linux-kernel - Re: [PATCH] power/reset: arm-versatile: Fix refcount leak in versatile_reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220609191411.uel3lw4yc7r6u5cs@mercury.elektranox.org>
Date:   Thu, 9 Jun 2022 21:14:11 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Miaoqian Lin <linmq006@...il.com>, Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power/reset: arm-versatile: Fix refcount leak in
 versatile_reboot_probe

Hi,

On Tue, May 24, 2022 at 09:25:48AM +0200, Linus Walleij wrote:
> On Mon, May 23, 2022 at 4:10 PM Miaoqian Lin <linmq006@...il.com> wrote:
> 
> > of_find_matching_node_and_match() returns a node pointer with refcount
> > incremented, we should use of_node_put() on it when not need anymore.
> > Add missing of_node_put() to avoid refcount leak.
> >
> > Fixes: 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")
> > Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> 
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Thanks, queued to power-supply's fixes branch.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)