linux-kernel - Re: [PATCH v2] power: supply: add dock type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220609202613.pjojjw7meb4bekfr@mercury.elektranox.org>
Date:   Thu, 9 Jun 2022 22:26:13 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Jack Wu <wjack@...gle.com>
Cc:     kernel-team@...roid.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Ken Yang <yangken@...gle.com>,
        AleX Pelosi <apelosi@...gle.com>,
        Vincent Wang <vincentwang@...gle.com>
Subject: Re: [PATCH v2] power: supply: add dock type

Hi,

On Mon, Mar 07, 2022 at 12:05:25PM +0800, Jack Wu wrote:
> Currently, power_supply framework supports only Battery, UPS,
> Mains, USB and WIRELESS power_supply_type. Add dock
> power_supply_type so that the drivers which supports dock can
> register a power supply class device with POWER_SUPPLY_TYPE_DOCK.

I asked for a driver using this. We do not add/extend sysfs API just
for the sake of downstream drivers. Either you send the
new driver/driver changes upstream that need POWER_SUPPLY_TYPE_DOCK,
or this will not get added.

Please don't waste reviewer's time!

-- Sebastian

> v2: updates to Documentation
> 
> Thanks!
> Jack
> 
> Jack Wu <wjack@...gle.com> 於 2022年3月7日 週一 上午11:44寫道：
> >
> > Add dock power_supply_type for the drivers which supports dock can
> > register a power supply class device with POWER_SUPPLY_TYPE_DOCK.
> >
> > Signed-off-by: Jack Wu <wjack@...gle.com>
> > ---
> >  Documentation/ABI/testing/sysfs-class-power | 2 +-
> >  drivers/power/supply/power_supply_sysfs.c   | 1 +
> >  include/linux/power_supply.h                | 1 +
> >  3 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> > index 859501366777..0b45d9d3a50f 100644
> > --- a/Documentation/ABI/testing/sysfs-class-power
> > +++ b/Documentation/ABI/testing/sysfs-class-power
> > @@ -34,7 +34,7 @@ Description:
> >                 Describes the main type of the supply.
> >
> >                 Access: Read
> > -               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless"
> > +               Valid values: "Battery", "UPS", "Mains", "USB", "Wireless", "Dock"
> >
> >  **Battery and USB properties**
> >
> > diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> > index c0dfcfa33206..2b1f18b7f98c 100644
> > --- a/drivers/power/supply/power_supply_sysfs.c
> > +++ b/drivers/power/supply/power_supply_sysfs.c
> > @@ -57,6 +57,7 @@ static const char * const POWER_SUPPLY_TYPE_TEXT[] = {
> >         [POWER_SUPPLY_TYPE_USB_PD_DRP]          = "USB_PD_DRP",
> >         [POWER_SUPPLY_TYPE_APPLE_BRICK_ID]      = "BrickID",
> >         [POWER_SUPPLY_TYPE_WIRELESS]            = "Wireless",
> > +       [POWER_SUPPLY_TYPE_DOCK]                = "Dock",
> >  };
> >
> >  static const char * const POWER_SUPPLY_USB_TYPE_TEXT[] = {
> > diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> > index e218041cc000..8f0425f00803 100644
> > --- a/include/linux/power_supply.h
> > +++ b/include/linux/power_supply.h
> > @@ -189,6 +189,7 @@ enum power_supply_type {
> >         POWER_SUPPLY_TYPE_USB_PD_DRP,           /* PD Dual Role Port */
> >         POWER_SUPPLY_TYPE_APPLE_BRICK_ID,       /* Apple Charging Method */
> >         POWER_SUPPLY_TYPE_WIRELESS,             /* Wireless */
> > +       POWER_SUPPLY_TYPE_DOCK,                 /* Dock Charging */
> >  };
> >
> >  enum power_supply_usb_type {
> > --
> > 2.35.1.616.g0bdcbb4464-goog
> >

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)