linux-kernel - Re: [PATCH v3 2/2] dt-bindings: aspeed-i2c: add properties for setting i2c clock duty cycle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220609203540.GA43168-robh@kernel.org>
Date:   Thu, 9 Jun 2022 14:35:40 -0600
From:   Rob Herring <robh@...nel.org>
To:     Potin Lai <potin.lai.pt@...il.com>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Rayn Chen <rayn_chen@...eedtech.com>,
        Patrick Williams <patrick@...cx.xyz>,
        Potin Lai <potin.lai@...ntatw.com>, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: aspeed-i2c: add properties for
 setting i2c clock duty cycle

On Wed, Jun 08, 2022 at 12:37:03AM +0800, Potin Lai wrote:
> Introduce a new property for setting a minimum duty cycle for clock high.
> 
> * i2c-clk-duty-cycle-min: a minimum percentage of clock high
> 
> Signed-off-by: Potin Lai <potin.lai.pt@...il.com>
> ---
>  Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> index ea643e6c3ef5..af4c49111cc0 100644
> --- a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml
> @@ -49,6 +49,14 @@ properties:
>      description:
>        states that there is another master active on this bus
>  
> +  i2c-clk-duty-cycle-min:

i2c-clk-duty-cycle-high-min-percent

Or maybe 'i2c-clk-high-min-percent' with duty cycle being implied.

> +    $ref: /schemas/types.yaml#/definitions/uint32

With '-percent' you can drop this.

> +    minimum: 1
> +    maximum: 100
> +    default: 50
> +    description:
> +      a minimum percentage of clock high
> +
>  required:
>    - reg
>    - compatible
> -- 
> 2.17.1
> 
>