linux-kernel - Re: [PATCH v4 1/1] nvme: handle persistent internal error AER from NVMe controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e57d8c2-9a30-f15e-dc38-da397ac81c34@nvidia.com>
Date:   Thu, 9 Jun 2022 00:22:45 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Michael Kelley <mikelley@...rosoft.com>,
        "kbusch@...nel.org" <kbusch@...nel.org>,
        "axboe@...com" <axboe@...com>, "hch@....de" <hch@....de>,
        "sagi@...mberg.me" <sagi@...mberg.me>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "caroline.subramoney@...rosoft.com" 
        <caroline.subramoney@...rosoft.com>,
        "riwurd@...rosoft.com" <riwurd@...rosoft.com>,
        "nathan.obr@...rosoft.com" <nathan.obr@...rosoft.com>
Subject: Re: [PATCH v4 1/1] nvme: handle persistent internal error AER from
 NVMe controller

On 6/8/22 11:52, Michael Kelley wrote:
> In the NVM Express Revision 1.4 spec, Figure 145 describes possible
> values for an AER with event type "Error" (value 000b). For a
> Persistent Internal Error (value 03h), the host should perform a
> controller reset.
> 
> Add support for this error using code that already exists for
> doing a controller reset. As part of this support, introduce
> two utility functions for parsing the AER type and subtype.
> 
> This new support was tested in a lab environment where we can
> generate the persistent internal error on demand, and observe
> both the Linux side and NVMe controller side to see that the
> controller reset has been done.
> 
> Signed-off-by: Michael Kelley <mikelley@...rosoft.com>
> ---


Looks good. Thanks a lot for testing this, perhaps consider
writing the testcase for it in  the blktests under nvme
category, that way it will get tested by everyone else.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck