linux-kernel - Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Jun 2022 00:22:39 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Zheng Bin <zhengbin13@...wei.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        gaochao49@...wei.com, Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH -next] power: supply: ab8500: add missing
 destroy_workqueue in ab8500_charger_bind

Hi,

On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> ab8500_charger_bind misses destroy_workqueue in error path,
> this patch fixes that.
> 
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
> ---

LGTM, but adding Linus to Cc and waiting a bit to give him time to
react.

-- Sebastian

>  drivers/power/supply/ab8500_charger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index d04d087caa50..a5d055a628e7 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
>  	ret = component_bind_all(dev, di);
>  	if (ret) {
>  		dev_err(dev, "can't bind component devices\n");
> +		destroy_workqueue(di->charger_wq);
>  		return ret;
>  	}
> 
> --
> 2.31.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)