linux-kernel - Re: [PATCH v2] hid: multitouch: new device class fix Lenovo X12 trackpad sticky

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2206091113370.14340@cbobk.fhfr.pm>
Date:   Thu, 9 Jun 2022 11:13:48 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Tao Jin <tao-j@...look.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hid: multitouch: new device class fix Lenovo X12
 trackpad sticky

On Thu, 19 May 2022, Tao Jin wrote:

> The trackpad of the given device sends continuous report of pointers
> status as per wxn8 spec. However, the spec did not clarify when the
> fingers are lifted so fast that between the interval of two report
> frames fingers on pad reduced from >=2 to 0. The second last report
> contains >=2 fingers with tip state 1 and the last report contains only
> 1 finger with tip state 0. Although this can happen unfrequently, a
>   quick fix will be improve the consistency to 100%. A quick fix is to
> disable MT_QUIRK_ALWAYS_VALID and enable MT_QUIRK_NOT_SEEN_MEANS_UP.
> 
> Test for hid-tools is added in [1]
> 
> In addition to this, I2C device 04CA:00B1 may also need similar class
> but with MT_QUIRK_FORCE_MULTI_INPUT disabled (but it does not harm to
>  enable it on non-multi-input device either). The respective owner has
> been notified and a patch may coming soon after test.
> 
> [1]: https://gitlab.freedesktop.org/libevdev/hid-tools/-/merge_requests/130
> 
> Signed-off-by: Tao Jin <tao-j@...look.com>

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs