linux-kernel - Re: [PATCH v3 1/2] dt-bindings: timer: mediatek: Add CPUX System Timer and MT6795 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1974b83e-967a-41ed-e790-52ceaf349ad3@collabora.com>
Date:   Thu, 9 Jun 2022 11:35:46 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Matthias Brugger <matthias.bgg@...il.com>,
        daniel.lezcano@...aro.org
Cc:     tglx@...utronix.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, konrad.dybcio@...ainline.org,
        marijn.suijten@...ainline.org, martin.botka@...ainline.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        paul.bouchara@...ainline.org
Subject: Re: [PATCH v3 1/2] dt-bindings: timer: mediatek: Add CPUX System
 Timer and MT6795 compatible

Il 07/06/22 18:11, Matthias Brugger ha scritto:
> 
> 
> On 18/05/2022 13:24, AngeloGioacchino Del Regno wrote:
>> Document the "CPUXGPT" CPU General Purpose Timer, used as ARM/ARM64
>> System Timer on MediaTek platforms and add the MT6795 compatible for it.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> ---
>>   .../devicetree/bindings/timer/mediatek,mtk-timer.txt          | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt 
>> b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> index 6f1f9dba6e88..49706cbef45d 100644
>> --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
>> @@ -2,6 +2,7 @@ MediaTek Timers
>>   ---------------
>>   MediaTek SoCs have two different timers on different platforms,
> 
> Nit: There are now three different timers so maybe:
> "MediaTek SoCs have different timers on different platforms,"
> 
> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
> 

Hi Matthias,
can we please ignore that description nit for this patch?

I was anyway planning to do a YAML conversion after getting this merged in, perhaps
we can just fix that on the new one instead?

Cheers,
Angelo

>> +- CPUX (ARM/ARM64 System Timer)
>>   - GPT (General Purpose Timer)
>>   - SYST (System Timer)
>> @@ -29,6 +30,9 @@ Required properties:
>>       * "mediatek,mt7629-timer" for MT7629 compatible timers (SYST)
>>       * "mediatek,mt6765-timer" for MT6765 and all above compatible timers (SYST)
>> +    For those SoCs that use CPUX
>> +    * "mediatek,mt6795-systimer" for MT6795 compatible timers (CPUX)
>> +
>>   - reg: Should contain location and length for timer register.
>>   - clocks: Should contain system clock.