linux-kernel - Re: [PATCH] s390: disable -Warray-bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 09 Jun 2022 11:56:14 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        David Howells <dhowells@...hat.com>
Cc:     Sven Schnelle <svens@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] s390: disable -Warray-bounds

Hi Linus,

On Mi, 2022-06-08 at 16:59 -0700, Linus Torvalds wrote:
> On Wed, Jun 8, 2022 at 2:33 PM Kees Cook <keescook@...omium.org> wrote:
> > 
> > I and others have been working through a bunch of them, though yes,
> > they're not all fixed yet. I've been trying to track it here[1], but
> > many of those fixes are only in -next.
> 
> Hmm. Even with that disabled, I get a few warnings I *really* would
> want to get rid of.
> 
> The one in ipuv3-crtc.c seems valid about "address used as boolean is
> always true".
> 
> The 'dangling-pointer' warning does seem interesting, but not when the
> compiler does as bad a job as gcc seems to do.
> 
> See the attached patch for
> 
>  (a) make the s390 "use -Wno-array-bounds for gcc-12" be generic
> 
>  (b) fix the ipuv3-crtc.c one. IMX people?

Thank you, this fix clearly matches the original intention.

Acked-by: Philipp Zabel <p.zabel@...gutronix.de>

The mistake had no adverse effect since the following condition doesn't
actually dereference the NULL pointer, but given the compiler warning
this

Fixes: eb8c88808c83 ("drm/imx: add deferred plane disabling")

regards
Philipp