linux-kernel - Re: [PATCH -next 1/2] spi: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YqHRlaqy/UD0vDKU@sirena.org.uk>
Date:   Thu, 9 Jun 2022 11:55:17 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     conor.dooley@...rochip.com, lewis.hanly@...rochip.com,
        linux-riscv@...ts.infradead.org, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next 1/2] spi: Remove unnecessary print function
 dev_err()

On Thu, Jun 09, 2022 at 01:55:33PM +0800, Yang Li wrote:
> The function platform_get_irq() never returns 0, and the print function
> dev_err() is redundant because platform_get_irq() already prints an error.

Are you sure it never returns 0?  Note that 0 is a valid IRQ number on
some architectures.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)