linux-kernel - Re: [PATCH] efi/x86: libstub: Fix typo in __efi64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXFvKAPzog7m4FFDLcGSO1F6nT5kzaDcyG635vy=UD0j6Q@mail.gmail.com>
Date:   Thu, 9 Jun 2022 13:46:36 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Evgeniy Baskov <baskov@...ras.ru>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>
Subject: Re: [PATCH] efi/x86: libstub: Fix typo in __efi64_argmap* name

On Thu, 9 Jun 2022 at 13:39, Evgeniy Baskov <baskov@...ras.ru> wrote:
>
> The actual name of the DXE services function used
> is set_memory_space_attributes(), not set_memory_space_descriptor().
>
> Change EFI mixed mode helper macro name to match the function name.
>
> Fixes: 31f1a0edff78 ("efi/x86: libstub: Make DXE calls mixed mode safe")
> Signed-off-by: Evgeniy Baskov <baskov@...ras.ru>

Thanks for the fix! I'll queue this up in efi/urgent


> ---
>  arch/x86/include/asm/efi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
> index 71943dce691e..9636742a80f2 100644
> --- a/arch/x86/include/asm/efi.h
> +++ b/arch/x86/include/asm/efi.h
> @@ -323,7 +323,7 @@ static inline u32 efi64_convert_status(efi_status_t status)
>  #define __efi64_argmap_get_memory_space_descriptor(phys, desc) \
>         (__efi64_split(phys), (desc))
>
> -#define __efi64_argmap_set_memory_space_descriptor(phys, size, flags) \
> +#define __efi64_argmap_set_memory_space_attributes(phys, size, flags) \
>         (__efi64_split(phys), __efi64_split(size), __efi64_split(flags))
>
>  /*
> --
> 2.36.1
>