linux-kernel - Re: [PATCH AUTOSEL 5.18 31/68] accessiblity: speakup: Add missing misc_deregister in softsynth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220609122839.35vn5vtukmuuxch3@begin>
Date:   Thu, 9 Jun 2022 14:28:39 +0200
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Zheng Bin <zhengbin13@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca,
        trix@...hat.com, salah.triki@...il.com, speakup@...ux-speakup.org
Subject: Re: [PATCH AUTOSEL 5.18 31/68] accessiblity: speakup: Add missing
 misc_deregister in softsynth_probe

Sasha Levin, le mar. 07 juin 2022 13:47:57 -0400, a ecrit:
> From: Zheng Bin <zhengbin13@...wei.com>
> 
> [ Upstream commit 106101303eda8f93c65158e5d72b2cc6088ed034 ]
> 
> softsynth_probe misses a call misc_deregister() in an error path, this
> patch fixes that.
> 
> Signed-off-by: Zheng Bin <zhengbin13@...wei.com>
> Link: https://lore.kernel.org/r/20220511032937.2736738-1-zhengbin13@huawei.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>

> ---
>  drivers/accessibility/speakup/speakup_soft.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c
> index 19824e7006fe..786dc5d080f3 100644
> --- a/drivers/accessibility/speakup/speakup_soft.c
> +++ b/drivers/accessibility/speakup/speakup_soft.c
> @@ -397,6 +397,7 @@ static int softsynth_probe(struct spk_synth *synth)
>  	synthu_device.name = "softsynthu";
>  	synthu_device.fops = &softsynthu_fops;
>  	if (misc_register(&synthu_device)) {
> +		misc_deregister(&synth_device);
>  		pr_warn("Couldn't initialize miscdevice /dev/softsynthu.\n");
>  		return -ENODEV;
>  	}
> -- 
> 2.35.1
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.