linux-kernel - Re: [PATCH v2] mm/vmscan: don't try to reclaim freed folios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e7178c73-9dbf-2d5f-735d-c23937fc9997@huawei.com>
Date:   Thu, 9 Jun 2022 11:04:02 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] mm/vmscan: don't try to reclaim freed folios

On 2022/6/9 2:47, Matthew Wilcox wrote:
> On Wed, Jun 08, 2022 at 10:14:32PM +0800, Miaohe Lin wrote:
>> If folios were freed from under us, there's no need to reclaim them. Skip
>> these folios to save lots of cpu cycles and avoid possible unnecessary
>> disk I/O.
> 
> Yes, but I asked how often this happened, and you said you didn't know.
> Do you have any data?  I'm reluctant to make a function which is over

This is just like the page_count == 1 case when doing page migration in unmap_and_move().

> 400 LOC already any longer.

I'm fine to resend this patch until your work is done (It will be really grateful if I
will be notified when that work is done).

Thanks!

> 
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>> ---
>> v2:
>>   use folio_ref_freeze to guard against race with GUP (fast). Many thanks
>>   Matthew for pointing this out.
>> ---
>>  mm/vmscan.c | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index 13d34d9593bb..547ae7ae6ab1 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -1610,13 +1610,19 @@ static unsigned int shrink_page_list(struct list_head *page_list,
>>  		folio = lru_to_folio(page_list);
>>  		list_del(&folio->lru);
>>  
>> +		nr_pages = folio_nr_pages(folio);
>> +
>> +		if (folio_ref_count(folio) == 1 &&
>> +		    folio_ref_freeze(folio, 1)) {
>> +			/* folio was freed from under us. So we are done. */
>> +			goto free_it;
>> +		}
>> +
>>  		if (!folio_trylock(folio))
>>  			goto keep;
>>  
>>  		VM_BUG_ON_FOLIO(folio_test_active(folio), folio);
>>  
>> -		nr_pages = folio_nr_pages(folio);
>> -
>>  		/* Account the number of base pages */
>>  		sc->nr_scanned += nr_pages;
>>  
>> -- 
>> 2.23.0
>>
> 
> .
>