linux-kernel - Re: [PATCH v2 -next] hwmon: (pmbus) fix build error unused-function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220609125417.GA1681487@roeck-us.net>
Date:   Thu, 9 Jun 2022 05:54:17 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Ren Zhijie <renzhijie2@...wei.com>
Cc:     jdelvare@...e.com, dev_public@...ek.eu,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 -next] hwmon: (pmbus) fix build error unused-function

On Thu, Jun 09, 2022 at 08:04:48PM +0800, Ren Zhijie wrote:
> If CONFIG_PMBUS is y and CONFIG_DEBUG_FS is not set.
> 
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-, will be failed, like this:
> drivers/hwmon/pmbus/pmbus_core.c:593:13: error: ‘pmbus_check_block_register’ defined but not used [-Werror=unused-function]
>  static bool pmbus_check_block_register(struct i2c_client *client, int page,
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[3]: *** [drivers/hwmon/pmbus/pmbus_core.o] Error 1
> make[2]: *** [drivers/hwmon/pmbus] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers/hwmon] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [drivers] Error 2
> 
> To fix building warning, use __maybe_unused to attach this func.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: c3ffc3a1ff83("hwmon: (pmbus) add a function to check the presence of a block register")
> Signed-off-by: Ren Zhijie <renzhijie2@...wei.com>

Applied.

Thanks,
Guenter

> ---
> v2: use __maybe_unused to attach this function, which Guenter suggested.
> ---
>  drivers/hwmon/pmbus/pmbus_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index 809e666cb52b..e6d3a1118453 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -590,7 +590,7 @@ bool pmbus_check_word_register(struct i2c_client *client, int page, int reg)
>  }
>  EXPORT_SYMBOL_NS_GPL(pmbus_check_word_register, PMBUS);
>  
> -static bool pmbus_check_block_register(struct i2c_client *client, int page,
> +static bool __maybe_unused pmbus_check_block_register(struct i2c_client *client, int page,
>  				       int reg)
>  {
>  	int rv;