linux-kernel - Re: [PATCH v6 2/5] i2c: npcm: Remove own slave addresses 2:10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACD3sJYEud8yagD-8m1UWYNmk7-gkg3R-kmK40Mf65cFb9N5eQ@mail.gmail.com>
Date:   Thu, 9 Jun 2022 20:59:44 +0800
From:   Tyrone Ting <warp5tw@...il.com>
To:     Wolfram Sang <wsa@...nel.org>, Tyrone Ting <warp5tw@...il.com>,
        avifishman70@...il.com, tmaimon77@...il.com, tali.perry1@...il.com,
        venture@...gle.com, yuenn@...gle.com, benjaminfair@...gle.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        andriy.shevchenko@...ux.intel.com, jarkko.nikula@...ux.intel.com,
        semen.protsenko@...aro.org, jsd@...ihalf.com, sven@...npeter.dev,
        lukas.bulwahn@...il.com, olof@...om.net, arnd@...db.de,
        tali.perry@...oton.com, Avi.Fishman@...oton.com,
        tomer.maimon@...oton.com, KWLIU@...oton.com, JJLIU0@...oton.com,
        kfting@...oton.com, openbmc@...ts.ozlabs.org,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/5] i2c: npcm: Remove own slave addresses 2:10

Hi Wolfram:

Thank you for your review and comments.

Wolfram Sang <wsa@...nel.org> 於 2022年6月9日 週四 上午4:02寫道：
>
> On Wed, May 25, 2022 at 11:23:38AM +0800, Tyrone Ting wrote:
> > From: Tali Perry <tali.perry1@...il.com>
> >
> > NPCM can support up to 10 own slave addresses. In practice, only one
> > address is actually being used. In order to access addresses 2 and above,
> > need to switch register banks. The switch needs spinlock.
> > To avoid using spinlock for this useless feature removed support of SA >=
> > 2. Also fix returned slave event enum.
> >
> > Remove some comment since the bank selection is not required. The bank
> > selection is not required since the supported slave addresses are reduced.
> >
> > Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
> > Signed-off-by: Tali Perry <tali.perry1@...il.com>
> > Signed-off-by: Tyrone Ting <kfting@...oton.com>
>
> Applied to for-next, thanks!
>

Best Regards,
Tyrone